Fix multi-output features not created when there is no child data#834
Merged
Merged
Conversation
rwedge
reviewed
Dec 5, 2019
| * Enhancements | ||
| * Fixes | ||
| * Raise error when given wrong input for ignore_variables (:pr:`826`) | ||
| * Fix multi-ouput features not created when there is no child data (:pr:`#834`) |
Contributor
There was a problem hiding this comment.
the '#' character should be removed
Contributor
|
I think the PR looks good, once the PR fixing the issue with sklearn and the tests goes through I think this will be good to go. |
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
==========================================
+ Coverage 98.15% 98.16% +<.01%
==========================================
Files 117 117
Lines 10848 10851 +3
==========================================
+ Hits 10648 10652 +4
+ Misses 200 199 -1
Continue to review full report at Codecov.
|
rwedge
approved these changes
Dec 18, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix multi-ouput features not created when there is no child data
When there is no child data,
calculate_feature_matrixraises aKeyErrorbecause multi-output features are not created. The expected behaviour is to have those features represented by columns filled by numpy.nan, as it is the case with regular features.Here is minimal reproducible example:
Created on 2019-12-05 by the reprexpy package
This PR fixes the bug and adds a test for multi-output feature in
test_empty_child_dataframe