New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi-output features not created when there is no child data #834
Fix multi-output features not created when there is no child data #834
Conversation
docs/source/changelog.rst
Outdated
@@ -6,14 +6,15 @@ Changelog | |||
* Enhancements | |||
* Fixes | |||
* Raise error when given wrong input for ignore_variables (:pr:`826`) | |||
* Fix multi-ouput features not created when there is no child data (:pr:`#834`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the '#' character should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I fixed it.
I think the PR looks good, once the PR fixing the issue with sklearn and the tests goes through I think this will be good to go. |
Codecov Report
@@ Coverage Diff @@
## master #834 +/- ##
==========================================
+ Coverage 98.15% 98.16% +<.01%
==========================================
Files 117 117
Lines 10848 10851 +3
==========================================
+ Hits 10648 10652 +4
+ Misses 200 199 -1
Continue to review full report at Codecov.
|
Fix multi-ouput features not created when there is no child data
When there is no child data,
calculate_feature_matrix
raises aKeyError
because multi-output features are not created. The expected behaviour is to have those features represented by columns filled by numpy.nan, as it is the case with regular features.Here is minimal reproducible example:
Created on 2019-12-05 by the reprexpy package
This PR fixes the bug and adds a test for multi-output feature in
test_empty_child_dataframe