Move sklearn wrapper to separate library #835
Conversation
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
=========================================
Coverage ? 98.15%
=========================================
Files ? 117
Lines ? 10848
Branches ? 0
=========================================
Hits ? 10648
Misses ? 200
Partials ? 0
Continue to review full report at Codecov.
|
requirements.txt
Outdated
| @@ -8,4 +8,4 @@ distributed>=1.24.2 | |||
| dask>=1.1.0 | |||
| psutil>=5.4.8 | |||
| click>=7.0.0 | |||
| scikit-learn>=0.20.0 | |||
| scikit-learn>=0.20.0,!=0.22 | |||
There was a problem hiding this comment.
is sklearn only used by the DFSWrapper? if so, maybe we should make it an optional dependency since that functionality is "beta" anyways
There was a problem hiding this comment.
Yeah it's only used in that wrapper
…turetools into fix-sklearn-wrapper-test
| @@ -26,20 +26,6 @@ Deep Feature Synthesis | |||
|
|
|||
| dfs | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
i think we can keep this in like we do for the nlp primitives. we just need to mention how to install
https://docs.featuretools.com/en/stable/api_reference.html#natural-language-processing-primitives
rwedge
changed the title
There's a bug (scikit-learn/scikit-learn/issues/15795) in the 0.22 release of scikit-learn that is breaking one of our test cases. Telling pip to ignore specifically the 0.22 release to avoid this bug.