Skip to content

Move sklearn wrapper to separate library#835

Merged
rwedge merged 23 commits into
masterfrom
fix-sklearn-wrapper-test
Dec 18, 2019
Merged

Move sklearn wrapper to separate library#835
rwedge merged 23 commits into
masterfrom
fix-sklearn-wrapper-test

Conversation

@rwedge
Copy link
Copy Markdown
Contributor

@rwedge rwedge commented Dec 5, 2019

There's a bug (scikit-learn/scikit-learn/issues/15795) in the 0.22 release of scikit-learn that is breaking one of our test cases. Telling pip to ignore specifically the 0.22 release to avoid this bug.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@cd674b3). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #835   +/-   ##
=========================================
  Coverage          ?   98.15%           
=========================================
  Files             ?      117           
  Lines             ?    10848           
  Branches          ?        0           
=========================================
  Hits              ?    10648           
  Misses            ?      200           
  Partials          ?        0
Impacted Files Coverage Δ
featuretools/utils/cli_utils.py 55.31% <ø> (ø)
featuretools/__init__.py 65.51% <ø> (ø)
featuretools/tests/utils_tests/test_cli_utils.py 100% <ø> (ø)
featuretools/version.py 100% <100%> (ø)
featuretools/tests/test_version.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd674b3...955609a. Read the comment docs.

@rwedge rwedge requested a review from kmax12 December 5, 2019 23:32
Comment thread requirements.txt Outdated
psutil>=5.4.8
click>=7.0.0
scikit-learn>=0.20.0
scikit-learn>=0.20.0,!=0.22
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is sklearn only used by the DFSWrapper? if so, maybe we should make it an optional dependency since that functionality is "beta" anyways

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's only used in that wrapper

@rwedge rwedge requested a review from kmax12 December 11, 2019 17:33
@rwedge rwedge changed the title Fix sklearn wrapper test Remove sklearn wrapper Dec 11, 2019
kmax12
kmax12 previously approved these changes Dec 13, 2019
Copy link
Copy Markdown
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just one comment


dfs


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we can keep this in like we do for the nlp primitives. we just need to mention how to install

https://docs.featuretools.com/en/stable/api_reference.html#natural-language-processing-primitives

@rwedge rwedge requested a review from kmax12 December 18, 2019 18:54
@rwedge rwedge changed the title Remove sklearn wrapper Move sklearn wrapper to separate library Dec 18, 2019
@rwedge rwedge merged commit cb82feb into master Dec 18, 2019
@rwedge rwedge deleted the fix-sklearn-wrapper-test branch December 18, 2019 19:56
@rwedge rwedge mentioned this pull request Dec 19, 2019
@rwedge rwedge mentioned this pull request Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants