Skip to content

Entry Point Warnings#850

Merged
jeff-hernandez merged 34 commits into
masterfrom
entry-points
Mar 12, 2020
Merged

Entry Point Warnings#850
jeff-hernandez merged 34 commits into
masterfrom
entry-points

Conversation

@jeff-hernandez

@jeff-hernandez jeff-hernandez commented Feb 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Plugins can fail to load silently at entry points. This PR closes #841 by warning users when plugins do fail to load.

@codecov-io

codecov-io commented Feb 20, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #850 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #850      +/-   ##
==========================================
+ Coverage   98.14%   98.18%   +0.04%     
==========================================
  Files         117      119       +2     
  Lines       10813    10849      +36     
==========================================
+ Hits        10612    10652      +40     
+ Misses        201      197       -4
Impacted Files Coverage Δ
featuretools/__init__.py 82.35% <100%> (+16.83%) ⬆️
featuretools/tests/plugin_tests/test_plugin.py 100% <100%> (ø)
featuretools/tests/plugin_tests/utils.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d346e...212624f. Read the comment docs.

rwedge
rwedge suggested changes Feb 20, 2020
View reviewed changes

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case that triggers this exception?

Comment thread featuretools/__init__.py Outdated
jeff-hernandez
jeff-hernandez commented Feb 27, 2020
View reviewed changes
Comment thread setup.cfg
rwedge
rwedge reviewed Feb 27, 2020
View reviewed changes
Comment thread featuretools/tests/plugin_tests/test_plugin.py Outdated
@jeff-hernandez
updates
c2f9cc5 
M  featuretools/tests/plugin_tests/featuretools_plugin/featuretools_plugin/__init__.py
M  featuretools/tests/plugin_tests/test_plugin.py
M  featuretools/tests/plugin_tests/utils.py
@jeff-hernandez
updates
7f61a6d 
M  featuretools/tests/plugin_tests/featuretools_plugin/featuretools_plugin/__init__.py
rwedge
rwedge reviewed Mar 5, 2020
View reviewed changes
Comment thread docs/source/changelog.rst Outdated
@jeff-hernandez jeff-hernandez requested a review from rwedge March 10, 2020 21:06
rwedge
rwedge suggested changes Mar 10, 2020
View reviewed changes

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also test not setting the logging level to debug and confirming the stack trace is not displayed?

Comment thread featuretools/__init__.py Outdated
@jeff-hernandez

jeff-hernandez commented Mar 11, 2020

Copy link
Copy Markdown
Contributor Author

Yes, will add that test case.

@jeff-hernandez jeff-hernandez requested a review from rwedge March 11, 2020 21:11
rwedge
rwedge reviewed Mar 11, 2020
View reviewed changes

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. From a user experience perspective, I don't think the warning mentions that they can see more info if logging is set to debug. We might want to mention that in the warning so they know that option exists.

rwedge
rwedge previously approved these changes Mar 11, 2020
View reviewed changes
@rwedge rwedge dismissed their stale review March 11, 2020 21:31

Accidentally approved it

@jeff-hernandez jeff-hernandez requested a review from rwedge March 12, 2020 15:33
rwedge
rwedge reviewed Mar 12, 2020
View reviewed changes
Comment thread featuretools/__init__.py Outdated
@jeff-hernandez jeff-hernandez requested a review from rwedge March 12, 2020 18:00
rwedge
rwedge approved these changes Mar 12, 2020
View reviewed changes

@rwedge rwedge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jeff-hernandez jeff-hernandez merged commit 40c740c into master Mar 12, 2020
@jeff-hernandez jeff-hernandez deleted the entry-points branch March 12, 2020 18:07
@frances-h frances-h mentioned this pull request Mar 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rwedge rwedge rwedge approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add warning if entry point plugin fails to load

3 participants

@jeff-hernandez @codecov-io @rwedge