-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entry Point Warnings #850
Entry Point Warnings #850
Conversation
Codecov Report
@@ Coverage Diff @@
## master #850 +/- ##
==========================================
+ Coverage 98.14% 98.18% +0.04%
==========================================
Files 117 119 +2
Lines 10813 10849 +36
==========================================
+ Hits 10612 10652 +40
+ Misses 201 197 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test case that triggers this exception?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also test not setting the logging level to debug and confirming the stack trace is not displayed?
Yes, will add that test case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. From a user experience perspective, I don't think the warning mentions that they can see more info if logging is set to debug. We might want to mention that in the warning so they know that option exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Plugins can fail to load silently at entry points. This PR closes #841 by warning users when plugins do fail to load.