Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc links to primitives.featurelabs.com #860

Merged
merged 4 commits into from
Mar 10, 2020
Merged

Conversation

thehomebrewnerd
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd commented Mar 6, 2020

Add links to primitives.featurelabs.com

Closes Issue #858

Added links in
-README.md
-Feature Primitives documentation page
-Primitives FAQ page
-Featuretools Enterprise page
-API Reference
-Sidebar

@kmax12
Copy link
Contributor

kmax12 commented Mar 6, 2020

Codecov Report

Merging #860 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #860   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files         117      117           
  Lines       10812    10812           
=======================================
  Hits        10611    10611           
  Misses        201      201           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc366f...2f148d6. Read the comment docs.

@thehomebrewnerd thehomebrewnerd requested a review from rwedge March 6, 2020 15:23
@rwedge rwedge requested a review from kmax12 March 6, 2020 16:47
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

I think let's also mention it here: https://docs.featuretools.com/en/stable/api_reference.html#feature-primitives

And can we add a direct link to it under "RESOURCES AND REFERENCES" in the side bar? Right below API reference? Call it "Primitive Reference".

Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. in case you're curious, I built the docs online to preview the change while I was reviewing: https://docs.featuretools.com/en/issue858/

@thehomebrewnerd thehomebrewnerd merged commit da8b5aa into master Mar 10, 2020
@thehomebrewnerd thehomebrewnerd deleted the issue858 branch March 10, 2020 14:25
@frances-h frances-h mentioned this pull request Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants