Skip to content

Make installed packages check case insensitive - #861

Merged
rwedge merged 2 commits into
masterfrom
debug-cli-test
Mar 10, 2020
Merged

rwedge merged 2 commits into
masterfrom
debug-cli-test

Conversation

@rwedge

@rwedge rwedge commented Mar 10, 2020

Copy link
Copy Markdown
Contributor

One of our tests related to the featuretools info command broke when a package changed the capitalization of its name. Package names are supposed to be case insensitive, so this PR updates the test to convert to lower case characters and replace hyphens with underscores.

@rwedge
rwedge requested a review from thehomebrewnerd March 10, 2020 18:04

@thehomebrewnerd thehomebrewnerd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwedge
rwedge merged commit 70003d6 into master Mar 10, 2020
@rwedge
rwedge deleted the debug-cli-test branch March 10, 2020 18:36
@frances-h frances-h mentioned this pull request Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants