Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make installed packages check case insensitive #861

Merged
merged 2 commits into from Mar 10, 2020
Merged

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Mar 10, 2020

One of our tests related to the featuretools info command broke when a package changed the capitalization of its name. Package names are supposed to be case insensitive, so this PR updates the test to convert to lower case characters and replace hyphens with underscores.

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwedge rwedge merged commit 70003d6 into master Mar 10, 2020
@rwedge rwedge deleted the debug-cli-test branch March 10, 2020 18:36
@frances-h frances-h mentioned this pull request Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants