Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ft showinfo notebook #863

merged 5 commits into from Mar 12, 2020

Fix ft showinfo notebook #863

merged 5 commits into from Mar 12, 2020


Copy link

@rwedge rwedge commented Mar 12, 2020

Resubmission of PR #690 so I could avoid making commits directly to the forked repo's master branch.

This fixes #650, where calling featureools.show_info in a jupyter notebook prints the output to the terminal running the notebook instead of printing in the notebook.

Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.


FreshLeaf8865 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rwedge rwedge requested a review from kmax12 March 12, 2020 21:27
Copy link
Collaborator Author

rwedge commented Mar 12, 2020

I have checked our list of signatories on CLAassistant and confirmed FreshLeaf8865 is on the list. I think the first commit in this PR uses a different email than is recognized by github so it is confusing the CLAassistant.

kmax12 approved these changes Mar 12, 2020
@rwedge rwedge merged commit 8540c28 into master Mar 12, 2020
@frances-h frances-h mentioned this pull request Mar 27, 2020
@rwedge rwedge deleted the fix-ft-showinfo-notebook branch April 15, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

ft.show_info() doesn't work in Jupyter
4 participants