Skip to content

Fix ft showinfo notebook - #863

Merged
rwedge merged 5 commits into
masterfrom
fix-ft-showinfo-notebook
Mar 12, 2020
Merged

Fix ft showinfo notebook#863
rwedge merged 5 commits into
masterfrom
fix-ft-showinfo-notebook

Conversation

@rwedge

@rwedge rwedge commented Mar 12, 2020

Copy link
Copy Markdown
Contributor

Resubmission of PR #690 so I could avoid making commits directly to the forked repo's master branch.

This fixes #650, where calling featureools.show_info in a jupyter notebook prints the output to the terminal running the notebook instead of printing in the notebook.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ rwedge
❌ FreshLeaf8865


FreshLeaf8865 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rwedge
rwedge requested a review from kmax12 March 12, 2020 21:27
@rwedge

rwedge commented Mar 12, 2020

Copy link
Copy Markdown
Contributor Author

I have checked our list of signatories on CLAassistant and confirmed FreshLeaf8865 is on the list. I think the first commit in this PR uses a different email than is recognized by github so it is confusing the CLAassistant.

@rwedge
rwedge merged commit 8540c28 into master Mar 12, 2020
@frances-h frances-h mentioned this pull request Mar 27, 2020
@rwedge
rwedge deleted the fix-ft-showinfo-notebook branch April 15, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ft.show_info() doesn't work in Jupyter

3 participants