Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logger.warning instead of logger.warn #871

Merged
merged 9 commits into from
Apr 2, 2020
Merged

Use logger.warning instead of logger.warn #871

merged 9 commits into from
Apr 2, 2020

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Apr 2, 2020 •
edited
Loading

Pull Request Description

@rwedge
Copy link
Contributor

rwedge commented Apr 2, 2020

Cool. Can you put the readme changes in a separate PR?

@gsheni
Copy link
Contributor Author

gsheni commented Apr 2, 2020

Cool. Can you put the readme changes in a separate PR?

Fixed

@gsheni gsheni changed the title Use logger.warning instead of logger.warn [WIP] Use logger.warning instead of logger.warn Apr 2, 2020
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #871 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #871   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         119      119           
  Lines       10850    10850           
=======================================
  Hits        10652    10652           
  Misses        198      198
Impacted Files Coverage Δ
featuretools/__init__.py 82.35% <100.00%> (ø)
featuretools/computational_backends/utils.py 94.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff3839a...dfb1032. Read the comment docs.

@gsheni gsheni changed the title [WIP] Use logger.warning instead of logger.warn Use logger.warning instead of logger.warn Apr 2, 2020
@gsheni gsheni requested a review from rwedge April 2, 2020 15:16
rwedge
rwedge approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit d0a43ac into master Apr 2, 2020
@rwedge rwedge deleted the fix_log_warning_method branch April 15, 2020 20:16
@frances-h frances-h mentioned this pull request Apr 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsheni @rwedge