Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uint8 dtype for one hot encoded features #876

merged 2 commits into from Apr 9, 2020


Copy link

@rwedge rwedge commented Apr 9, 2020

Resolves #875 .

Changes the dtype used for the one-hot encoded feature columns in encode_features to use the same dtype as pandas.get_dummies

Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #876 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #876   +/-   ##
  Coverage   98.17%   98.17%           
  Files         119      119           
  Lines       10850    10850           
  Hits        10652    10652           
  Misses        198      198           
Impacted Files Coverage Δ
featuretools/synthesis/ 98.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0a43ac...a5f9613. Read the comment docs.

@rwedge rwedge requested review from kmax12 and gsheni and removed request for kmax12 April 9, 2020 21:00
gsheni approved these changes Apr 9, 2020
Copy link

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@rwedge rwedge merged commit 157f2cd into master Apr 9, 2020
@rwedge rwedge deleted the use-smaller-int-type-one-hot branch April 9, 2020 21:13
@frances-h frances-h mentioned this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Improve memory consumption by downsizing data type for encoded features
2 participants