Skip to content

Fix hyperlinks in docs and docstrings with updated address#910

Merged
gsheni merged 9 commits intomasterfrom
fix_ecosystem_link
Apr 16, 2020
Merged

Fix hyperlinks in docs and docstrings with updated address#910
gsheni merged 9 commits intomasterfrom
fix_ecosystem_link

Conversation

@gsheni
Copy link
Copy Markdown
Contributor

@gsheni gsheni commented Apr 15, 2020

Pull Request Description

  • The ecosystem is incorrect and doesn't currently work. This PR fixes that.
  • There are additional links which have the same problem, and this PR addresses that.

@gsheni gsheni self-assigned this Apr 15, 2020
@gsheni gsheni requested a review from rwedge April 15, 2020 19:57
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2020

Codecov Report

Merging #910 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #910   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         119      119           
  Lines       10850    10850           
=======================================
  Hits        10652    10652           
  Misses        198      198           
Impacted Files Coverage Δ
featuretools/computational_backends/utils.py 94.11% <ø> (ø)
featuretools/entityset/entityset.py 96.48% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73b9e3b...281f859. Read the comment docs.

@rwedge
Copy link
Copy Markdown
Contributor

rwedge commented Apr 15, 2020

Can you do a sweep of the repo for any other links that references specific pages on docs.featuretools.com and are missing the /en/stable/ part of the path?

@gsheni gsheni changed the title Fix Ecosystem Link Fix Docs Link Apr 15, 2020
@gsheni
Copy link
Copy Markdown
Contributor Author

gsheni commented Apr 15, 2020

Can you do a sweep of the repo for any other links that references specific pages on docs.featuretools.com and are missing the /en/stable/ part of the path?

There was 2 more in the docstrings that I fixed.

@gsheni gsheni changed the title Fix Docs Link Fix hyperlinks in docs and docstrings with updated address Apr 15, 2020
@rwedge
Copy link
Copy Markdown
Contributor

rwedge commented Apr 15, 2020

I think there's another link in docs/source/templates/layout.html that needs to be fixed

@gsheni
Copy link
Copy Markdown
Contributor Author

gsheni commented Apr 15, 2020

I think there's another link in docs/source/templates/layout.html that needs to be fixed

Fixed.

I thought changing the link would not work since it was a static image. So I skipped it on my review. But the new link worked.

Copy link
Copy Markdown
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit 31ace1c into master Apr 16, 2020
@gsheni gsheni deleted the fix_ecosystem_link branch April 16, 2020 15:52
@frances-h frances-h mentioned this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants