Remove Overlap in Training Windows #930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #930 +/- ##
=======================================
Coverage 98.17% 98.17%
=======================================
Files 119 119
Lines 10861 10867 +6
=======================================
+ Hits 10663 10669 +6
Misses 198 198
Continue to review full report at Codecov.
|
rwedge
reviewed
Apr 28, 2020
rightx2
added a commit
to rightx2/featuretools
that referenced
this pull request
Apr 30, 2020
Closed
|
Please review my pull request |
Merged
This was referenced May 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #918 by making the left endpoint of a training window exclusive. This will avoid overlap in consecutive training windows.