Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dtype to interesting_values #933

Merged
merged 4 commits into from Apr 29, 2020
Merged

Add dtype to interesting_values #933

merged 4 commits into from Apr 29, 2020

Conversation

frances-h
Copy link
Contributor

  • Add dtype to interesting_values to silence Pandas DeprecationWarning

Fixes #928

@frances-h frances-h requested a review from rwedge April 29, 2020 15:04
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #933 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #933   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         119      119           
  Lines       10850    10861   +11     
=======================================
+ Hits        10652    10663   +11     
  Misses        198      198           
Impacted Files Coverage Δ
featuretools/entityset/entity.py 95.68% <100.00%> (ø)
featuretools/tests/entityset_tests/test_entity.py 100.00% <100.00%> (ø)
featuretools/variable_types/variable.py 98.30% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 903a473...fb78613. Read the comment docs.

rwedge
rwedge previously approved these changes Apr 29, 2020
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better

@frances-h frances-h merged commit b516ae7 into master Apr 29, 2020
@frances-h frances-h deleted the interesting-vals-dtype branch April 29, 2020 20:06
@frances-h frances-h mentioned this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning with empty Series and no dtype
2 participants