Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to get default primitives #945

Merged
merged 9 commits into from
May 7, 2020
Merged

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented May 7, 2020

Pull Request Description

  • Add get_default_aggregation_primitives and get_default_transform_primitives to primitives.utils
  • Have DFS run these functions to get the default primitives. In addition, users can call these functions to get the list of primitives.
  • Rename test file from test_list_primitives.py to test_primitives_utils.py since the file tests functions in the utils of primitives

@gsheni gsheni requested a review from rwedge May 7, 2020 18:20
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #945 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #945   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files         119      119           
  Lines       10859    10873   +14     
=======================================
+ Hits        10666    10680   +14     
  Misses        193      193           
Impacted Files Coverage Δ
featuretools/primitives/api.py 100.00% <ø> (ø)
featuretools/primitives/utils.py 99.08% <100.00%> (+0.05%) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 97.04% <100.00%> (ø)
...retools/tests/utils_tests/test_primitives_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16a4e0...49e5a19. Read the comment docs.

Gaurav Sheni added 2 commits May 7, 2020 15:49
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of adding these to the list of ft.primitives.utils functions callable from ft.primitives (currently get_aggregation_primitives, get_transformation_primitives, and list_primitives are like that)

docs/source/changelog.rst Outdated Show resolved Hide resolved
@gsheni
Copy link
Contributor Author

gsheni commented May 7, 2020

What do you think of adding these to the list of ft.primitives.utils functions callable from ft.primitives (currently get_aggregation_primitives, get_transformation_primitives, and list_primitives are like that)

Yep, sounds good. Added it to the api.py

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit 84fb795 into master May 7, 2020
@rwedge rwedge mentioned this pull request May 29, 2020
@rwedge rwedge deleted the get_default_primitives branch June 17, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants