-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions to get default primitives #945
Conversation
Codecov Report
@@ Coverage Diff @@
## master #945 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 119 119
Lines 10859 10873 +14
=======================================
+ Hits 10666 10680 +14
Misses 193 193
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of adding these to the list of ft.primitives.utils
functions callable from ft.primitives
(currently get_aggregation_primitives
, get_transformation_primitives
, and list_primitives
are like that)
Yep, sounds good. Added it to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Pull Request Description
get_default_aggregation_primitives
andget_default_transform_primitives
to primitives.utilstest_list_primitives.py
totest_primitives_utils.py
since the file tests functions in the utils of primitives