EntitySet.concat() reindexes relationships #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=========================================
- Coverage 87.62% 87.6% -0.02%
=========================================
Files 73 73
Lines 7191 7207 +16
=========================================
+ Hits 6301 6314 +13
- Misses 890 893 +3
Continue to review full report at Codecov.
|
kmax12
reviewed
Feb 20, 2018
| for i, related in index_map.items(): | ||
| if i not in other.indexed_by[v]: | ||
| return False | ||
| if not (np.sort(related) == np.sort(other.indexed_by[v][i])).all(): |
There was a problem hiding this comment.
can you leave a comment in the code what this line is checking?
kmax12
reviewed
Feb 20, 2018
| # indexed_by maps instances of two entities together by lists | ||
| # We want to check that all the elements of the lists of instances | ||
| # for each relationship are the same in both entities being | ||
| # checked for equality, but don't care about the order. | ||
| if not (np.sort(related) == np.sort(other.indexed_by[v][i])).all(): |
There was a problem hiding this comment.
thanks for the comment. can this line just be set(related) != set(other.indexed_by[v][i])?
There was a problem hiding this comment.
yeah that should work too
|
Looks good. merging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #83