Conversation
Codecov Report
@@ Coverage Diff @@
## master #968 +/- ##
=======================================
Coverage 98.23% 98.24%
=======================================
Files 119 119
Lines 10905 10945 +40
=======================================
+ Hits 10713 10753 +40
Misses 192 192
Continue to review full report at Codecov.
|
rwedge
reviewed
May 19, 2020
frances-h
force-pushed
the
equal-not-equal-fix
branch
from
4f1462b to
495e5b5
Compare
rwedge
reviewed
May 21, 2020
| }) | ||
|
|
||
| es = ft.EntitySet('not_equal_test') | ||
| es.entity_from_dataframe('values', df, index='id') |
Contributor
There was a problem hiding this comment.
can we make this entityset a fixture use by both tests to avoid duplicated code?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #922 and #944
.eqinstead ofnumpy.equal