Update handling of cutoff time dataframe columns #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be in instance_id_time, ... order. This commit addresses this issue by first moving the expected columns to the first and second position before cracking on with the rest of the code
Codecov Report
@@ Coverage Diff @@
## master #969 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 119 119
Lines 10873 10901 +28
=======================================
+ Hits 10680 10708 +28
Misses 193 193
Continue to review full report at Codecov.
|
rwedge
reviewed
May 19, 2020
featuretools/tests/computational_backend/test_calculate_feature_matrix.py
Show resolved
Hide resolved
rwedge
reviewed
May 20, 2020
This was referenced May 20, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off of #549 and serves as a replacement for that PR. This PR also adds additional functionality in the handling of the cutoff time dataframe time columns so that both the time and instance id columns can be in any order in the cutoff time dataframe as long as they are named properly.
Acceptable instance id column names: target entity index variable name or
instance_idAcceptable time column names: target entity time_index variable name or
time.Also updated the tests and documentation impacted by this change.
Note, this update will be a breaking change for users who previously depended on column ordering to identify the time column in a cutoff time dataframe.
Closes Issue #487