Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update handling of cutoff time dataframe columns #969

merged 10 commits into from May 20, 2020


Copy link

This PR builds off of #549 and serves as a replacement for that PR. This PR also adds additional functionality in the handling of the cutoff time dataframe time columns so that both the time and instance id columns can be in any order in the cutoff time dataframe as long as they are named properly.

Acceptable instance id column names: target entity index variable name or instance_id
Acceptable time column names: target entity time_index variable name or time.

Also updated the tests and documentation impacted by this change.

Note, this update will be a breaking change for users who previously depended on column ordering to identify the time column in a cutoff time dataframe.

Closes Issue #487

sebrahimi1988 and others added 3 commits May 19, 2019 21:46
… to be in instance_id_time, ... order. This commit addresses this issue by first moving the expected columns to the first and second position before cracking on with the rest of the code
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #969 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #969   +/-   ##
  Coverage   98.22%   98.22%           
  Files         119      119           
  Lines       10873    10901   +28     
+ Hits        10680    10708   +28     
  Misses        193      193           
Impacted Files Coverage Δ
featuretools/synthesis/ 100.00% <ø> (ø)
...computational_backends/ 98.61% <100.00%> (+0.02%) ⬆️
...utational_backend/ 99.40% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a89d81...b07e375. Read the comment docs.

docs/source/changelog.rst Outdated Show resolved Hide resolved
Copy link

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants