Skip to content

Docstring Update for Entityset #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2020
Merged

Docstring Update for Entityset #986

merged 5 commits into from
May 22, 2020

Conversation

ctduffy
Copy link
Contributor

@ctduffy ctduffy commented May 21, 2020

Closes #984, expands docstring description for entityset, makes it consistent throughout.

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #986 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #986   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files         119      119           
  Lines       10945    10945           
=======================================
  Hits        10753    10753           
  Misses        192      192           
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 98.61% <ø> (ø)
featuretools/entityset/entityset.py 96.48% <ø> (ø)
featuretools/synthesis/dfs.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f270d5...db3ba73. Read the comment docs.

@ctduffy ctduffy requested a review from thehomebrewnerd May 21, 2020 15:41
@ctduffy ctduffy marked this pull request as ready for review May 21, 2020 15:45
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor adjustments. Also, be sure to add your name to the list of contributors in changelog.rst (line 19)

@ctduffy ctduffy requested a review from thehomebrewnerd May 21, 2020 21:26
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ctduffy ctduffy merged commit ec3b8ce into master May 22, 2020
@ctduffy ctduffy deleted the 984docs branch May 22, 2020 13:37
@rwedge rwedge mentioned this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docstring mismatch between dfs method and EntitySet
2 participants