Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Age Primitive, and Unit tests for Age Primitive #987

Merged
merged 12 commits into from May 22, 2020
Merged

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented May 21, 2020

Pull Request Description

@gsheni gsheni requested review from rwedge and ctduffy May 21, 2020 17:10
@gsheni gsheni self-assigned this May 21, 2020
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #987 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #987   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         119      119           
  Lines       10985    11030   +45     
=======================================
+ Hits        10793    10838   +45     
  Misses        192      192           
Impacted Files Coverage Δ
...retools/primitives/standard/transform_primitive.py 100.00% <100.00%> (ø)
featuretools/primitives/utils.py 99.08% <100.00%> (ø)
...ests/primitive_tests/test_feature_serialization.py 99.31% <100.00%> (+<0.01%) ⬆️
...s/tests/primitive_tests/test_transform_features.py 98.57% <100.00%> (+0.01%) ⬆️
.../tests/primitive_tests/test_transform_primitive.py 100.00% <100.00%> (ø)
...retools/tests/utils_tests/test_primitives_utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a71d57b...e02a0b4. Read the comment docs.

docs/source/changelog.rst Outdated Show resolved Hide resolved
@rwedge
Copy link
Contributor

rwedge commented May 22, 2020

Looks like adding an new default primitive changed the expected features for our deserialize from S3 tests

@gsheni
Copy link
Contributor Author

gsheni commented May 22, 2020

Looks like adding an new default primitive changed the expected features for our deserialize from S3 tests

Fixed this by having the deserialize tests use a fixed list of agg and trans primitives

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gsheni gsheni merged commit 7b7e4ce into master May 22, 2020
@gsheni gsheni deleted the add_age_primitive branch May 22, 2020 17:21
@rwedge rwedge mentioned this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dfs doesn't use TimeSince primitives on datetime features
4 participants