New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use primitive classes or instances in primitive options #993
Conversation
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
=======================================
Coverage 98.25% 98.26%
=======================================
Files 121 121
Lines 12338 12397 +59
=======================================
+ Hits 12123 12182 +59
Misses 215 215
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
docs/source/changelog.rst
Outdated
@@ -21,7 +21,8 @@ Changelog | |||
* Allow cutoff time dataframe columns to be in any order (:pr:`969`, :pr:`995`) | |||
* Add Age primitive, and make it a default transform primitive for DFS (:pr:`987`) | |||
* Add ``include_cutoff_time`` arg - control whether data at cutoff times are included in feature calculations (:pr:`959`) | |||
* Allow ``variables_types`` to be referenced by their ``type_string`` | |||
* Add ability to use primitive classes and instances as keys in primitive_options dictionary (:pr:`993`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be moved to the Future Release section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
primitive_options
Resolves #980