Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use primitive classes or instances in primitive options #993

Merged
merged 15 commits into from Jun 5, 2020
Merged

Use primitive classes or instances in primitive options #993

merged 15 commits into from Jun 5, 2020

Conversation

frances-h
Copy link
Contributor

@frances-h frances-h commented May 22, 2020 •
edited

  • allow use of primitive classes or primitive instances as keys in primitive_options
  • primitive instance will only use its options, even if generic options for the primitive class are present in the options dictionary
  • update the FAQ and tutorial to reflect changes

Resolves #980

@codecov
Copy link

codecov bot commented May 22, 2020 •
edited

Codecov Report

Merging #993 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #993   +/-   ##
=======================================
  Coverage   98.25%   98.26%           
=======================================
  Files         121      121           
  Lines       12338    12397   +59     
=======================================
+ Hits        12123    12182   +59     
  Misses        215      215
Impacted Files Coverage Δ
featuretools/primitives/options_utils.py 100.00% <100.00%> (ø)
featuretools/synthesis/deep_feature_synthesis.py 97.34% <100.00%> (ø)
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.22% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 996c189...b2a1b6f. Read the comment docs.

@frances-h frances-h requested a review from rwedge May 22, 2020 21:54
@frances-h frances-h requested a review from rwedge May 29, 2020 13:22
thehomebrewnerd
thehomebrewnerd previously approved these changes Jun 3, 2020
View reviewed changes
Copy link
Collaborator

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

rwedge
rwedge reviewed Jun 5, 2020
View reviewed changes
docs/source/changelog.rst Outdated
@@ -21,7 +21,8 @@ Changelog
* Allow cutoff time dataframe columns to be in any order (:pr:`969`, :pr:`995`)
* Add Age primitive, and make it a default transform primitive for DFS (:pr:`987`)
* Add ``include_cutoff_time`` arg - control whether data at cutoff times are included in feature calculations (:pr:`959`)
* Allow ``variables_types`` to be referenced by their ``type_string``
* Add ability to use primitive classes and instances as keys in primitive_options dictionary (:pr:`993`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be moved to the Future Release section

rwedge
rwedge approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@frances-h frances-h merged commit 0f35678 into master Jun 5, 2020
@frances-h frances-h deleted the primitive_option_fix branch June 5, 2020 17:54
@rwedge rwedge mentioned this pull request Jun 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

@thehomebrewnerd thehomebrewnerd thehomebrewnerd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I created Multiple Input Primitives,but the primitive_options is invalid.
3 participants
@frances-h @thehomebrewnerd @rwedge