Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error if target entity time index is 'time' or index is 'instance_id' #995

Merged
merged 3 commits into from
May 26, 2020

Conversation

frances-h
Copy link
Contributor

Add additional checks in case entity index is instance_id or entity time index is time

Fixes #994

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #995 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #995   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         119      119           
  Lines       11030    11030           
=======================================
  Hits        10838    10838           
  Misses        192      192           
Impacted Files Coverage Δ
...computational_backends/calculate_feature_matrix.py 98.61% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b7e4ce...7b28b9a. Read the comment docs.

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frances-h frances-h merged commit f8d42c4 into master May 26, 2020
@frances-h frances-h deleted the fix-time-index-time branch May 26, 2020 16:02
@rwedge rwedge mentioned this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculate feature matrix fails if target entity time index is 'time'
3 participants