Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialization guide to docs #1066

Merged
merged 27 commits into from Jul 29, 2021
Merged

Add serialization guide to docs #1066

merged 27 commits into from Jul 29, 2021

Conversation

jeff-hernandez
Copy link
Contributor

Closes #866

@codecov
Copy link

codecov bot commented Jul 22, 2021 •
edited

Codecov Report

Merging #1066 (d62dd16) into main (b25e2e5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1066   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        46           
  Lines         8156      8156           
=========================================
  Hits          8156      8156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25e2e5...d62dd16. Read the comment docs.

@gsheni gsheni requested review from thehomebrewnerd, davesque and tuethan1999 and removed request for thehomebrewnerd July 22, 2021 20:19
@jeff-hernandez jeff-hernandez marked this pull request as ready for review July 27, 2021 18:53
@gsheni gsheni requested a review from rwedge July 27, 2021 20:38
@gsheni gsheni requested a review from rwedge July 28, 2021 19:10
rwedge
rwedge approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jeff-hernandez jeff-hernandez merged commit e0cdbcf into main Jul 29, 2021
@jeff-hernandez jeff-hernandez deleted the serialization_guide branch July 29, 2021 17:57
@davesque davesque mentioned this pull request Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehomebrewnerd thehomebrewnerd thehomebrewnerd left review comments

@gsheni gsheni gsheni left review comments

@rwedge rwedge rwedge approved these changes

@davesque davesque Awaiting requested review from davesque

@tuethan1999 tuethan1999 Awaiting requested review from tuethan1999

Assignees

@jeff-hernandez jeff-hernandez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add serialization/deserialization guide to documentation
4 participants
@jeff-hernandez @thehomebrewnerd @rwedge @gsheni