Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to provide callback to describe #1387

Merged
merged 9 commits into from Apr 21, 2022
Merged

Conversation

ParthivNaresh
Copy link
Collaborator

Fixes: #940

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1387 (bc52017) into main (3ab4225) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1387   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files          97       97           
  Lines       10389    10420   +31     
=======================================
+ Hits        10385    10416   +31     
  Misses          4        4           
Impacted Files Coverage Δ
woodwork/statistics_utils/_get_describe_dict.py 100.00% <100.00%> (ø)
woodwork/table_accessor.py 100.00% <100.00%> (ø)
woodwork/tests/accessor/test_statistics.py 99.49% <100.00%> (+0.01%) ⬆️
woodwork/tests/conftest.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab4225...bc52017. Read the comment docs.

@ParthivNaresh ParthivNaresh marked this pull request as ready for review April 20, 2022 19:38
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Left one rec on buffing up the test, but not blocking!

woodwork/tests/accessor/test_statistics.py Outdated Show resolved Hide resolved
@ParthivNaresh ParthivNaresh merged commit 9989073 into main Apr 21, 2022
@ParthivNaresh ParthivNaresh mentioned this pull request Apr 22, 2022
@gsheni gsheni deleted the add_results_callback branch July 18, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add intermediate results to describe
3 participants