New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dask an optional dependency #357
Conversation
Codecov Report
@@ Coverage Diff @@
## main #357 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 3320 3342 +22
=========================================
+ Hits 3320 3342 +22
Continue to review full report at Codecov.
|
8e59086
to
5e6fae1
Compare
5e6fae1
to
8a8f1f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the CircleCI config we may be running codecov block twice (starting with the when condition on line 86). If I'm reading this right, this block will run any time we are running python 3.6. We should only run this when we have the optional libraries installed and python 3.6. I'm not great with digesting config.yml files, so I might be wrong.
Maybe take a look at what featuretools does for comparison:
https://github.com/FeatureLabs/featuretools/blob/c51ef4e2944bb754de5696833b480b316916202a/.circleci/config.yml#L170-L173
Other than that, I only noticed a couple other relatively minor things.
The reason for the quotes is because some shells (like zsh) use square brackets for pattern matching while other shells (like bash) don't. Adding quotes makes it work for all shells. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things. Looks good overall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
pip install woodwork[dask]
todo: