Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding shape to DataTable and DataColumn #358

Merged
merged 6 commits into from Nov 5, 2020
Merged

Adding shape to DataTable and DataColumn #358

merged 6 commits into from Nov 5, 2020

Conversation

ctduffy
Copy link
Contributor

@ctduffy ctduffy commented Nov 5, 2020

@gsheni gsheni changed the title Adding shape to DataTable and DataColumn Adding shape to DataTable and DataColumn Nov 5, 2020
gsheni
gsheni suggested changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall. Just minor doc things

woodwork/data_column.py
@@ -273,6 +273,12 @@ def to_series(self):
"""
return self._series

@property
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to api_reference

woodwork/data_table.py
@@ -203,6 +203,12 @@ def semantic_tags(self):
"""A dictionary containing semantic tags for each column"""
return {dc.name: dc.semantic_tags for dc in self.columns.values()}

@property
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to api_reference

@codecov
Copy link

codecov bot commented Nov 5, 2020 •
edited

Codecov Report

Merging #358 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #358   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         3294      3320   +26     
=========================================
+ Hits          3294      3320   +26
Impacted Files Coverage Δ
woodwork/data_column.py 100.00% <100.00%> (ø)
woodwork/data_table.py 100.00% <100.00%> (ø)
woodwork/tests/data_column/test_data_column.py 100.00% <100.00%> (ø)
woodwork/tests/data_table/test_datatable.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4be6b85...7ec72df. Read the comment docs.

@gsheni gsheni merged commit e4435e9 into main Nov 5, 2020
@gsheni gsheni deleted the shape-attr branch November 5, 2020 23:44
@kmax12 kmax12 mentioned this pull request Nov 6, 2020
Closed
@gsheni gsheni mentioned this pull request Nov 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsheni gsheni gsheni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shape attribute to DataTable/DataColumn
2 participants
@ctduffy @gsheni