Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FullName to PersonFullName #740

Merged
merged 6 commits into from Mar 29, 2021
Merged

Change FullName to PersonFullName #740

merged 6 commits into from Mar 29, 2021

Conversation

jeff-hernandez
Copy link
Contributor

Closes #695 by renaming FullName logical type to PersonFullName.

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #740 (8881c6a) into main (deb6a83) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #740   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        46           
  Lines         6181      6181           
=========================================
  Hits          6181      6181           
Impacted Files Coverage Δ
woodwork/type_sys/type_system.py 100.00% <ø> (ø)
woodwork/logical_types.py 100.00% <100.00%> (ø)
woodwork/tests/accessor/test_statistics.py 100.00% <100.00%> (ø)
woodwork/tests/accessor/test_table_accessor.py 100.00% <100.00%> (ø)
woodwork/tests/schema/test_schema.py 100.00% <100.00%> (ø)
woodwork/tests/type_system/test_type_system.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deb6a83...8881c6a. Read the comment docs.

@jeff-hernandez jeff-hernandez marked this pull request as ready for review March 29, 2021 16:50
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeff-hernandez jeff-hernandez merged commit b178f92 into main Mar 29, 2021
@jeff-hernandez jeff-hernandez deleted the person_full_name branch March 29, 2021 19:47
@tamargrey tamargrey mentioned this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change FullName to PersonFullName
3 participants