Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColumnSchema repr #817

Merged
merged 3 commits into from Apr 15, 2021
Merged

Add ColumnSchema repr #817

merged 3 commits into from Apr 15, 2021

Conversation

tamargrey
Copy link
Contributor

@tamargrey tamargrey commented Apr 14, 2021

  • The repr only show logical type and semantic tags, and if either is not present, doesn't include it in the repr (treats empty semantic tags list as not present, which is good for Featuretools' use but not for the ColumnAccessor, so the Column Accessor will not inherit this behavior)
  • Closes Add ColumnSchema repr #798

Note: This repr will be used to look at a Featuretools primitive's input and return types, so it's important that this is functional for that purpose.

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #817 (f2cc593) into main (c88e129) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #817   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           46        46           
  Lines         6563      6576   +13     
=========================================
+ Hits          6563      6576   +13     
Impacted Files Coverage Δ
woodwork/column_schema.py 100.00% <100.00%> (ø)
woodwork/tests/schema/test_column_schema.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c88e129...f2cc593. Read the comment docs.

Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rwedge
Copy link
Contributor

rwedge commented Apr 14, 2021

Unrelated, the ColumnSchema docstring references a "name" parameter which doesn't exist

@tamargrey
Copy link
Contributor Author

Unrelated, the ColumnSchema docstring references a "name" parameter which doesn't exist

Removed--thanks for pointing out @rwedge!

@tamargrey tamargrey merged commit 8359fb1 into main Apr 15, 2021
@tamargrey tamargrey deleted the schema-repr branch April 15, 2021 17:51
@tamargrey tamargrey mentioned this pull request Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ColumnSchema repr
5 participants