Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peggy Stargate migration and code clean up #115

Closed
wants to merge 24 commits into from

Conversation

jackzampolin
Copy link

@jackzampolin jackzampolin commented Nov 16, 2020

Ok! So we have a building peggy sdk@v0.40.0-rc3 (🌟 Stargate 🌟 ) version 🎉 🚀 🙌 🧑‍🚀 The following are remaining TODOs for the stargate work in the rough order I think they should be tackled in:

  • audit types in ./proto to ensure that naming is consistent and types have necessary information
    • Update type props in rust module/x/peggy/keeper/querier_test.go in this PR has the field changes
  • tests passing ./x/peggy/types/..., main issue here is ethereum address encoding/decoding
    • TestValidateMsgSetEthAddress failing, signature needs to be updated
  • tests passing ./x/peggy/keeper/... main issue here is formatting of the querier returns
    • TestAllValsetConfirmsBynonce failing, iterator not working properly
  • tests passing in ./x/peggy/... handler test issues will likely be resolved by fixing /types and /keeper tests
  • Refactors:
    • Remove BridgeDenom
    • Remove VoucherDenom
    • Remove Uint64Nonce
  • e2e peggy tests passing
  • gRPC query implemenetation
  • gRPC tx implementation
  • simulation for the peggy module and wire up those sims to CI
  • implement invariants for peggy if applicable
  • reimplement the CLI with full peggy functionality

@jackzampolin jackzampolin marked this pull request as ready for review November 19, 2020 21:14
@jackzampolin jackzampolin changed the title WIP Stargate migration Peggy Stargate migration and code clean up Nov 19, 2020
@jackzampolin
Copy link
Author

Ok, since I've now got the gRPC stuff implemented (tx side only stubbed out for now cause we don't have a usecase) I'm marking this r4r. Would like to get #114 and #118 into this PR before merge too

@jkilpatr
Copy link
Member

closed in favor of #120

@jkilpatr jkilpatr deleted the jack/stargate-1 branch April 11, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants