Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support paths #108

Merged
merged 2 commits into from Dec 11, 2020
Merged

Support paths #108

merged 2 commits into from Dec 11, 2020

Conversation

flying-sheep
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #108 (e5a6c43) into master (3712629) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #108   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files          29       29           
  Lines        2812     2813    +1     
  Branches      476      476           
=======================================
+ Hits         2336     2337    +1     
  Misses        351      351           
  Partials      125      125           
Impacted Files Coverage Δ
pronto/ontology.py 91.48% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3712629...1523a1d. Read the comment docs.

@althonos
Copy link
Owner

Since we are updating there, we should probably support everything that is os.PathLike. Can you update your PR to use os.fspath instead?

@flying-sheep
Copy link
Contributor Author

Sure, done!

@althonos
Copy link
Owner

Cool, thanks! I will figure out how to fix #109 and then push a new release.

@althonos althonos merged commit e3a61fe into althonos:master Dec 11, 2020
@flying-sheep flying-sheep deleted the patch-1 branch December 11, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants