refactor: extract cmd_status 3-tier fallback + add tests#67
Merged
Conversation
cmd_status's owner/RO/FTS fallback ladder extracted into _status_via_owner, _status_via_ro_open, _status_via_fts (+ _empty_status_source for the shared dict shape). cmd_status selects the first tier whose counts_source != 'none' (same order/conditions) and renders once. Rendered output unchanged. Adds tests/test_cli/test_status_fallback.py covering the dict shape and the RO and FTS tiers without spawning an owner. Pure readability + tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REFACTOR-4. cmd_status fallback extracted into _status_via_owner/_status_via_ro_open/_status_via_fts (+ _empty_status_source); renders once, output unchanged. New test_status_fallback.py (9 tests). Rebased onto current develop and re-applies the #60 status-display fix (would create graph.duckdb, Endpoints: unknown).