Skip to content

Improvements to github-comment#20

Merged
aluzzardi merged 3 commits into
aluzzardi:mainfrom
shykes:github-comment-url
Feb 7, 2025
Merged

Improvements to github-comment#20
aluzzardi merged 3 commits into
aluzzardi:mainfrom
shykes:github-comment-url

Conversation

@shykes
Copy link
Copy Markdown
Contributor

@shykes shykes commented Feb 7, 2025

  • Private fields for cleaner API
  • Support passing the repo as a single string
  • API docs

Signed-off-by: Solomon Hykes <solomon@dagger.io>
Examples of supported values:

- dagger/dagger
- github.com/dagger/dagger
- https://github.com/dagger/dagger
- https://github.com/dagger/dagger.git

This makes the API simpler and more flexible (callers don't need to split owner and name from url themselves)

Signed-off-by: Solomon Hykes <solomon@dagger.io>
Signed-off-by: Solomon Hykes <solomon@dagger.io>
@aluzzardi aluzzardi merged commit ee43f9e into aluzzardi:main Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants