Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookies setting fix after puppeteer update #83

Merged
merged 2 commits into from Feb 13, 2019

Conversation

Projects
None yet
3 participants
@esvitaly
Copy link
Contributor

commented Sep 19, 2018

Page.setCookies not working anymore due to the new version of puppeteer. Now, you can't set cookies with this function if page not loaded. This pull request fixes this problem by using chrome devtools protocol session. (Issue #62)

@esvitaly esvitaly changed the title Fixing cookies setting after puppeteer update Cookies setting fix after puppeteer update Sep 19, 2018

@esvitaly esvitaly referenced this pull request Oct 27, 2018

Closed

cookies #88

@mblarsen

This comment has been minimized.

Copy link

commented Dec 11, 2018

Would love to see this get merged

@kimmobrunfeldt kimmobrunfeldt merged commit 495287c into alvarcarto:master Feb 13, 2019

@kimmobrunfeldt

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Thanks for the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.