Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves scrollOverflow code to separate handler object #1498

Closed
wants to merge 12 commits into from

Conversation

rmarscher
Copy link
Contributor

This update adds a new option called 'scrollOverflowHandler'
which consolidates all code related to scrollOverflow and
allows it to be swapped out with different functionality.

By default, it will use the existing jquery.slimScroll handling
of scroll overflow.

This should make it easier for users to either customize the
slimScroll handling or replace it with other code just as wrapping
content in a div with overflow: scroll or utilizing iscroll.js
as requested in issues #506, #612 and others.

@rmarscher
Copy link
Contributor Author

Created a gist with a potential alternative iscroll-based handler for scrollOverflow.

@alvarotrigo
Copy link
Owner

Thanks for it!!
Looks like we have some beautiful code out there! :)

I'll take a deeper look at it, maybe not that much as a way to expect other developers to create their own handler, but more as a way to allow them to choose between using iScroll.js or slimScroll.js. (or even use a fallback for IE < 10 if slimScroll.js is present)

@rmarscher
Copy link
Contributor Author

Thanks, @alvarotrigo! I'm sure maintaining this library is a lot of work. I hope this helps.

@alvarotrigo
Copy link
Owner

Hi @rmarscher, can you please create a new branch with it?
I'll merge it there to keep working on other features for the next release.

@alvarotrigo
Copy link
Owner

If you can remove the hidden file .editorconfig from it, that'd good.

@rmarscher rmarscher force-pushed the scroll-overflow-handler branch 2 times, most recently from 6ac0bc1 to 9218fac Compare September 21, 2015 22:04
@rmarscher
Copy link
Contributor Author

Hi @alvarotrigo - sorry it took me a few days to respond. I removed the .editorconfig file from the project. But I would recommend adding it as it helps contributors preserve your line endings and indent-style.

I don't think I have permission to create a new branch in this repo. I think you would need to create and push the branch. Then I can close this pull request and submit a new one against that branch. Let me know once that has been done. Thanks!

@alvarotrigo
Copy link
Owner

But I would recommend adding it as it helps contributors preserve your line endings and indent-style.

Ok, feel free to add it again.

Let me know once that has been done.

Done. Its called dev

@alvarotrigo
Copy link
Owner

I'll be adding new commits into the branch these days, you might need to update your copy before commiting it again if it finds conflicts.

@alvarotrigo
Copy link
Owner

I will probably commit the current branch today or tomorrow.
If you still want to commit the changes then that'd probably be for 2 releases ahead.

If you just don't have time for the merging let me know and I'll add the changes by myself.

@rmarscher
Copy link
Contributor Author

Closing. Re-submitted against the dev branch in #1543. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants