New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves scrollOverflow code to separate handler object #1498
Conversation
Created a gist with a potential alternative iscroll-based handler for scrollOverflow. |
Thanks for it!! I'll take a deeper look at it, maybe not that much as a way to expect other developers to create their own handler, but more as a way to allow them to choose between using iScroll.js or slimScroll.js. (or even use a fallback for IE < 10 if slimScroll.js is present) |
Thanks, @alvarotrigo! I'm sure maintaining this library is a lot of work. I hope this helps. |
Hi @rmarscher, can you please create a new branch with it? |
If you can remove the hidden file |
6ac0bc1
to
9218fac
Compare
Hi @alvarotrigo - sorry it took me a few days to respond. I removed the .editorconfig file from the project. But I would recommend adding it as it helps contributors preserve your line endings and indent-style. I don't think I have permission to create a new branch in this repo. I think you would need to create and push the branch. Then I can close this pull request and submit a new one against that branch. Let me know once that has been done. Thanks! |
…ts happening) - Fixed bug alvarotrigo#1499
Ok, feel free to add it again.
Done. Its called |
I'll be adding new commits into the branch these days, you might need to update your copy before commiting it again if it finds conflicts. |
I will probably commit the current branch today or tomorrow. If you just don't have time for the merging let me know and I'll add the changes by myself. |
- Adding a link to the readme index.
9218fac
to
106de42
Compare
106de42
to
a48e5b2
Compare
Closing. Re-submitted against the dev branch in #1543. Thanks. |
This update adds a new option called 'scrollOverflowHandler'
which consolidates all code related to scrollOverflow and
allows it to be swapped out with different functionality.
By default, it will use the existing jquery.slimScroll handling
of scroll overflow.
This should make it easier for users to either customize the
slimScroll handling or replace it with other code just as wrapping
content in a div with
overflow: scroll
or utilizing iscroll.jsas requested in issues #506, #612 and others.