Ensure that adding/updating a resource won't get others removed #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvis
changed the title
alvis
force-pushed
the
fix/unexpected-node-update
branch
from
1b8b806 to
aefbfbb
Compare
alvis
changed the title
alvis
force-pushed
the
fix/unexpected-node-update
branch
2 times, most recently
from
3ff0733 to
960798a
Compare
alvis
changed the title
Previously, contentDigest is computed together with a node's children including its content and id. Therefore, if a child get updated, its parent node will get an unexpected updated with a new digestContent, triggering the old parent node getting removed together with its children, i.e. the updated child's siblings. This update will address this issue by excluding the child's content but their ids into the computation of digestContent.
alvis
force-pushed
the
fix/unexpected-node-update
branch
from
960798a to
c97d301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, contentDigest is computed together with a node's children including its content and id. Therefore, if a child get updated, its parent node will get an unexpected updated with a new digestContent, triggering the old parent node getting removed together with its children, i.e. the updated child's siblings.
This update will address this issue by excluding the child's content but their ids into the computation of digestContent.
PR installable via
Fix #1