Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistics: Add offset to ReportPresent/ReportComposed #1361

Merged
merged 2 commits into from Jan 12, 2023

Conversation

nowrep
Copy link
Collaborator

@nowrep nowrep commented Jan 8, 2023

It is needed for accurate timings with Vulkan.

@nowrep nowrep force-pushed the stats-offset branch 2 times, most recently from 39bc75e to e9c2b0a Compare January 8, 2023 13:54
@nowrep nowrep changed the title Statistics: Add offset to Report functions Statistics: Add offset to ReportPresent/ReportComposed Jan 8, 2023
@zarik5
Copy link
Member

zarik5 commented Jan 11, 2023

This PR doesn't make use of the offset yet.

@nowrep
Copy link
Collaborator Author

nowrep commented Jan 11, 2023

It doesn't, because I think it's better as separate commit. But if you prefer to include the Vulkan changes too, I'll update it.

@zarik5
Copy link
Member

zarik5 commented Jan 11, 2023

But if you prefer to include the Vulkan changes too, I'll update it.

Yes go ahead with the adding the Vulkan changes.

It is needed for accurate timing with Vulkan.
Server compositor no longer includes time spent waiting on game
to finish rendering frames.
@Vixea Vixea self-requested a review January 11, 2023 16:13
@Vixea Vixea merged commit 49b6707 into alvr-org:master Jan 12, 2023
zarik5 pushed a commit that referenced this pull request Feb 10, 2023
* Statistics: Add offset to ReportPresent/ReportComposed

It is needed for accurate timing with Vulkan.

* Vulkan: Use timestamp queries to get more accurate latency values

Server compositor no longer includes time spent waiting on game
to finish rendering frames.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants