-
Notifications
You must be signed in to change notification settings - Fork 0
Adding request logging #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds request logging functionality to the Oxylabs API client using the always-open/laravel-request-logger package. Integrates logging for all API requests with configurable enable/disable functionality.
- Introduced centralized request handling with logging capability
- Added database migration for request log storage
- Refactored existing request methods to use unified logging approach
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/OxylabsApiClient.php | Refactored to use centralized makeRequest method with integrated logging |
| src/Models/OxylabsApiRequestLogger.php | New model extending base request logger for Oxylabs API requests |
| src/OxylabsApiServiceProvider.php | Added conditional migration publishing based on logging config |
| config/oxylabs-api.php | Added request logging configuration option |
| database/migrations/* | Added migration for request logger table and removed old stub |
| tests/* | Updated test fixtures and added logging disable for test environments |
| composer.json | Added dependency on request logger package |
Comments suppressed due to low confidence (1)
database/migrations/2000_01_01_000001_create_oxylabs_api_reqeust_logger_table.php:1
- Filename contains a typo: 'reqeust' should be 'request'.
<?php
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
database/migrations/2000_01_01_000001_create_oxylabs_api_reqeust_logger_table.php
Outdated
Show resolved
Hide resolved
…st_logger_table.php Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/oxylabs-api into feature/add-optional-logging
Description
Release Notes
Suggested details for the release notes to explain how this impacts users
Types of changes
Checklist