Skip to content

Conversation

@qschmick
Copy link
Member

@qschmick qschmick commented Sep 4, 2025

Description

Release Notes

Suggested details for the release notes to explain how this impacts users

Types of changes

  • Bugfix
  • New feature
  • Chore (mundane code change)
  • Maintenance (clean up)

Checklist

  • Unit tests pass locally
  • Added tests to code that was updated or edited
  • Updated/added documentation

@qschmick qschmick requested a review from Copilot September 4, 2025 14:41
@qschmick qschmick self-assigned this Sep 4, 2025
@qschmick qschmick added the enhancement New feature or request label Sep 4, 2025
@qschmick qschmick requested review from Copilot and removed request for Copilot September 4, 2025 14:49

This comment was marked as outdated.

@qschmick qschmick requested a review from Copilot September 4, 2025 15:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds request logging functionality to the Oxylabs API client using the always-open/laravel-request-logger package. Integrates logging for all API requests with configurable enable/disable functionality.

  • Introduced centralized request handling with logging capability
  • Added database migration for request log storage
  • Refactored existing request methods to use unified logging approach

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/OxylabsApiClient.php Refactored to use centralized makeRequest method with integrated logging
src/Models/OxylabsApiRequestLogger.php New model extending base request logger for Oxylabs API requests
src/OxylabsApiServiceProvider.php Added conditional migration publishing based on logging config
config/oxylabs-api.php Added request logging configuration option
database/migrations/* Added migration for request logger table and removed old stub
tests/* Updated test fixtures and added logging disable for test environments
composer.json Added dependency on request logger package
Comments suppressed due to low confidence (1)

database/migrations/2000_01_01_000001_create_oxylabs_api_reqeust_logger_table.php:1

  • Filename contains a typo: 'reqeust' should be 'request'.
<?php

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

qschmick and others added 4 commits September 4, 2025 11:03
…st_logger_table.php

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/oxylabs-api into feature/add-optional-logging
@qschmick qschmick merged commit 765c32a into main Sep 4, 2025
4 checks passed
@qschmick qschmick deleted the feature/add-optional-logging branch September 4, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

2 participants