Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the Mobile View of the Website[Responsive] #268

Closed
AM1CODES opened this issue Oct 9, 2020 · 19 comments
Closed

Fixing the Mobile View of the Website[Responsive] #268

AM1CODES opened this issue Oct 9, 2020 · 19 comments
Labels
bug Something isn't working Hacktoberfest Hacktoberfest2020 IMPORTANT

Comments

@AM1CODES
Copy link
Owner

AM1CODES commented Oct 9, 2020

Screenshot_2020-10-09-08-56-22-687_com android chrome
The Mobile view of the website is broken, need someone to fix it asap.
Thank you.
@FireLemons
Copy link
Contributor

can I have this assigned?

@AM1CODES
Copy link
Owner Author

AM1CODES commented Oct 9, 2020

can I have this assigned?

Yes its assigned to you. You can start working on it.

This was referenced Oct 9, 2020
Merged
Closed
@AM1CODES
Copy link
Owner Author

Thank you for contributing! The website is responsive now. Just one thing, the up arrow at the bottom of the page is a little misalligned, so if you can bring it to center again, it would be great and just the like - "Show us your favourite pokemons" could be brought a little bit up in the mobile version so that the down arrow can fit in better. Thank you.

@FireLemons
Copy link
Contributor

wait what happened wasn't there a comment about the header text still being misaligned vertically?

@FireLemons
Copy link
Contributor

can you send a screenshot of what you just described?

@FireLemons
Copy link
Contributor

did you clear the cache? I'm gonna try pulling it up on my laptop to see if anything is different

@AM1CODES
Copy link
Owner Author

Yes yes that part is cleared, it was an error on my part. Just the above mentioned issue is remaining rn.

@AM1CODES
Copy link
Owner Author

Screenshot_2020-10-10-09-00-58-348_com android chrome
Screenshot_2020-10-10-09-00-51-365_com android chrome
i was talking about these two things, if the down button could be shifted a little up.

@FireLemons
Copy link
Contributor

ahh I see. I can re create the bug on chrome. It should be fixable

@FireLemons
Copy link
Contributor

@AM1CODES could you please mark that merged pull request as hacktoberfest-accepted so it counts towards the 4/4 goal?

@AM1CODES
Copy link
Owner Author

ahh I see. I can re create the bug on chrome. It should be fixable

Okay. Try and work on it and see what changes you can make to it. Thank you.

@AM1CODES
Copy link
Owner Author

Yes i will label it as well

@srishtij2000
Copy link
Contributor

Can I work on this issue?

@FireLemons
Copy link
Contributor

@srishtij2000 I want to share a little thing I noticed when first examining the issue: The width of the header would change after the page finished loading some element which takes several seconds but not longer than a minute.

@srishtij2000
Copy link
Contributor

So are you going to assign this issue or should I just submit the PR?

@FireLemons
Copy link
Contributor

yeah just submit a pr

@srishtij2000
Copy link
Contributor

Okay okay

@srishtij2000
Copy link
Contributor

I have issued a PR so kindly review it

@AM1CODES
Copy link
Owner Author

This issue has been solved. Thank you for contributing @srishtij2000 @FireLemons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Hacktoberfest Hacktoberfest2020 IMPORTANT
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FireLemons @AM1CODES @srishtij2000