Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing cdk stack #15

Merged
merged 4 commits into from
Jul 7, 2021
Merged

Testing cdk stack #15

merged 4 commits into from
Jul 7, 2021

Conversation

tehzwen
Copy link
Contributor

@tehzwen tehzwen commented Jul 7, 2021

No description provided.

* Add tests for cdk base stack and custom resources stack
* Update CDK test to look for new IAM Policy
* Add CDK Assert 1.111 to project for testing
@tehzwen tehzwen requested a review from a team as a code owner July 7, 2021 18:18
Copy link
Contributor

@jessedoyle jessedoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I think there may be a console.log used for debugging left over.

__tests__/cdk/custom-resources-base-stack.test.ts Outdated Show resolved Hide resolved
* Remove duplicate license
Copy link
Contributor

@jessedoyle jessedoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, nice tests!

@tehzwen tehzwen merged commit 95f70b7 into lex-v2-integration Jul 7, 2021
@tehzwen tehzwen deleted the testing-cdk-stack branch July 7, 2021 19:16
jessedoyle pushed a commit that referenced this pull request Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants