New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing outdated sonarqube and adding dotnet core tests #248
Conversation
# Conflicts: # appveyor.yml # src/QLNet/QLNet.csproj
@@ -2,7 +2,7 @@ | |||
|
|||
<PropertyGroup> | |||
<VersionPrefix>1.11.3</VersionPrefix> | |||
<TargetFrameworks>net452;netstandard1.2;netstandard2.0</TargetFrameworks> | |||
<TargetFrameworks>netstandard1.2;netstandard2.0</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing the net452
target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because netstandard1.2 can be used by net4.5.1 and above, so it is redundant. https://docs.microsoft.com/en-us/dotnet/standard/net-standard
I think you guys were a bit quick to just drop a target framework. We were explicitly supporting older versions of Visual Studio through the So do we want to support older version of Visual Studio (and then also .NET 4.5.2) or do we decide that every developer should be on a later (I think 2017+) version of Visual Studio? |
No description provided.