Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing outdated sonarqube and adding dotnet core tests #248

Merged
merged 11 commits into from Apr 2, 2020

Conversation

potatman
Copy link
Contributor

@potatman potatman commented Apr 2, 2020

No description provided.

@@ -2,7 +2,7 @@

<PropertyGroup>
<VersionPrefix>1.11.3</VersionPrefix>
<TargetFrameworks>net452;netstandard1.2;netstandard2.0</TargetFrameworks>
<TargetFrameworks>netstandard1.2;netstandard2.0</TargetFrameworks>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing the net452 target?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because netstandard1.2 can be used by net4.5.1 and above, so it is redundant. https://docs.microsoft.com/en-us/dotnet/standard/net-standard

@amaggiulli amaggiulli merged commit 3dce73f into amaggiulli:develop Apr 2, 2020
@igitur
Copy link
Collaborator

igitur commented Apr 3, 2020

I think you guys were a bit quick to just drop a target framework. We were explicitly supporting older versions of Visual Studio through the QLNetOld.sln and QLNet.Old.csproj files. That project relies on a net452 build. If we drop .NET Framework support, that means people who build QLNet themselves will require a later version of Visual Studio and hence we can drop the "old" .sln and .csproj files. At the moment we're sitting with a half-baked implementation.

So do we want to support older version of Visual Studio (and then also .NET 4.5.2) or do we decide that every developer should be on a later (I think 2017+) version of Visual Studio?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants