Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arbitrary domains #3

Merged
merged 9 commits into from Sep 27, 2020
Merged

Add support for arbitrary domains #3

merged 9 commits into from Sep 27, 2020

Conversation

mohd-akram
Copy link
Contributor

Closes #2.

Tested with go run go2port.go -d get github.com/caddyserver/caddy v2.1.1.

@amake amake merged commit 88a8c92 into amake:master Sep 27, 2020
@amake
Copy link
Owner

amake commented Sep 27, 2020

Thank you for your contribution.

I had to make various changes, most notably disabling the special handling of go.googlesource.com. The reason is that in my testing go.googlesource.com serves a different (i.e. checksum doesn't match) tarball each time you download. Such a service can't reliably used as a host for distfiles in MacPorts.

@mohd-akram
Copy link
Contributor Author

Thanks for merging! Issue for reference - google/gitiles#84.

@amake
Copy link
Owner

amake commented Sep 27, 2020

Ah, thanks very much for that 👍

@mohd-akram mohd-akram deleted the support-domains branch September 27, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for arbitrary domains
2 participants