Minor style improvements.

amakelov · Aug 6, 2012 · 8820277 · 8820277
1 parent fabddb8
commit 8820277
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/sympy/combinatorics/named_groups.py b/sympy/combinatorics/named_groups.py
@@ -70,13 +70,13 @@ def AlternatingGroup(n):
 
     """
     # small cases are special
-    if n == 1 or n == 2:
+    if n in (1, 2):
         return PermutationGroup([Permutation([0])])
 
     a = range(n)
     a[0], a[1], a[2] = a[1], a[2], a[0]
     gen1 = _new_from_array_form(a)
-    if n % 2 == 1:
+    if n % 2:
         a = range(1, n)
         a.append(0)
         gen2 = _new_from_array_form(a)

diff --git a/sympy/combinatorics/perm_groups.py b/sympy/combinatorics/perm_groups.py
@@ -475,7 +475,7 @@ def _random_pr_init(self, r, n, _random_prec_n=None):
         Notes
         =====
 
-        THIS FUNCTION HAS SIDE EFFECTS: it changes the attribute
+        XXX THIS FUNCTION HAS SIDE EFFECTS: it changes the attribute
         self._random_gens
 
         See Also
@@ -1732,7 +1732,7 @@ def orbit(self, alpha, action='tuples'):
                         orb.append(temp)
                         used[temp] = True
             return set(orb)
-        if action == 'tuples':
+        elif action == 'tuples':
             alpha = tuple(alpha)
             orb = [alpha]
             used = set([alpha])
@@ -1744,7 +1744,7 @@ def orbit(self, alpha, action='tuples'):
                         orb.append(temp)
                         used.add(temp)
             return set(orb)
-        if action == 'sets':
+        elif action == 'sets':
             alpha = frozenset(alpha)
             orb = [alpha]
             used = set([alpha])