Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for requiring any scope. #114

Merged
merged 3 commits into from Aug 16, 2021

Conversation

@neverendingqs
Copy link
Contributor

@neverendingqs neverendingqs commented Aug 13, 2021

Currently, if requireScope is set to true, this action also assumes that scope is a non-empty list. If scope is not provided and a pull request title does not include one, the action fails with:

Error: Cannot read property 'join' of undefined

This is because the action assumes scope will be defined: https://github.com/amannn/action-semantic-pull-request/blob/master/src/validatePrTitle.js#L53-L59

This pull request proposes that scope doesn't have to be defined. If it is not, then any scope is permissible as long as one is provided in the pull request title.

Quality notes:

@amannn
Copy link
Owner

@amannn amannn commented Aug 16, 2021

Really great PR, thanks a lot for your work!

Can you fix the reported lint errors? Afterwards this should be good to go.

@amannn amannn merged commit 4c0fe2f into amannn:master Aug 16, 2021
3 checks passed
@github-actions
Copy link

@github-actions github-actions bot commented Aug 16, 2021

🎉 This PR is included in version 3.4.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@neverendingqs neverendingqs deleted the feat/noscopeallowlist branch Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants