Incorrect space generated for MFD in mpc_permafrost

[ecoon]

Daniil, I can fix this, but I don't understand the NLFV branch of the code starting from here:

ats/src/pks/mpc/mpc_permafrost.cc

Line 90 in 7d00e2d

std::string pk0_method = pks_list_->sublist(names[0]).sublist("diffusion").get<std::string>("discretization primary");

through line 102.

The bug is that when the discretization is MFD, the CVS needs to get FACE, not BOUNDARY_FACE (e.g. at line 98).

But why is this constructed this way? Should it really be an Operator_FaceCell for NLFV, or should it instead be an Operator_CellBndFace?

[ecoon]

Sorry, the link got broken when I pushed the fix. I updated the link to the old version.

[ecoon]

Reopening so Daniil sees this. Please close it if Operator_FaceCell is correct for NLFV.

[dasvyat]

Ethan, mpc_permafrost.cc looks OK to me.