Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

major cleanup of PKs #64

Merged
merged 15 commits into from
Nov 4, 2020
Merged

major cleanup of PKs #64

merged 15 commits into from
Nov 4, 2020

Conversation

ecoon
Copy link
Collaborator

@ecoon ecoon commented Sep 10, 2020

This does some significant refactoring and cleanup on PKs, especially flow, energy, and transport, to standardize how things work across ATS PKs.

See commit messages below -- this closes a lot of tickets.

@ecoon
sets the ATS default partitioner to be zoltan_rcp, e.g. "map view" pa…
05c245a 
…rtitioning of columns. closes #61
@ecoon
major cleanup of PKs.
1a107ae 
* moves multiple evaluators out of PKs and into the more typical evaluator list
* cleans up use of common geometric/mesh shortcut functions
* standardizes the use of keys in PKs

closes #49
closes #39
closes #38
closes #35
closes #33
closes #3
@ecoon
updates plotting and xdmf to the new default vis file name
8fdfe85
@ecoon
tweaks initial conditions and boundary conditions based on head and l…
ca0225c 
…evel water table conditions. closes #62 closes #63
@ecoon
Copy link
Collaborator Author

ecoon commented Sep 10, 2020 •
edited
Loading

note this is blocked by a pull request on Amanzi, amanzi/amanzi#497

@ecoon
Copy link
Collaborator Author

ecoon commented Oct 8, 2020

Note that this significantly changes the transport input spec.

  1. Previously, source and boundary condition lists were nested inside of two separate arbitrarily named lists (e.g. "boundary conditions" --> "arbitrary 1" --> "arbitrary 2" --> bc spec object). This has been reduced to one flattened list.
  2. The "inverse" list is now used at the top level of the PK list, as in all other ATS PKs, instead of a list buried inside of the dispersion/diffusion lists.
  3. "initial conditions" is now required inside the PK, as in all other ATS PKs.
  4. porosity, saturation_liquid, and density are now evaluators, not just fields.
  5. The "special source" option is no longer used -- this is always done, and has been integrated into the same passes as the AdvanceTime methods. Similarly, the methods that supplied the special source values are removed from coupling MPCs.

@ecoon ecoon requested a review from ajkhattak October 14, 2020 15:59
ajkhattak
ajkhattak approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@ajkhattak ajkhattak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@ecoon
adds input conversion from 0.88 to 1.0. Note this does very little bu…
532acf7 
…t fix a common bug -- there were no significant input spec changes from 0.88 to 1.0
@ecoon
Significant changes to surface flow + energy equations.
6229916 
This makes updates to the surface flow and energy, especially with
attention to the coupled surface problem.  Improves testing, and
resurrects the ice dam problem.

Also updates the input spec converters to match the current
versioning.
@ecoon
Copy link
Collaborator Author

ecoon commented Nov 4, 2020

All ATS tests pass, merging all three PRs (Amanzi, ATS, ats-regression-tests)

@ecoon ecoon merged commit 8a72665 into master Nov 4, 2020
This was referenced Nov 12, 2020
Closed
Closed
This was referenced Nov 12, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkhattak ajkhattak ajkhattak approved these changes

@dasvyat dasvyat Awaiting requested review from dasvyat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecoon @ajkhattak