Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to name SplitResources based resources (like LEDResources, ButtonResources...) #189

Closed
hansfbaier opened this issue Dec 19, 2021 · 5 comments
Labels

Comments

@hansfbaier
Copy link

hansfbaier commented Dec 19, 2021

Currently it is not possible to create those with a different name than their default name,
which is hardwired.

@bl0x
Copy link

bl0x commented Jan 23, 2022

I made a proposal on how to solve this:

PR: #192

@hansfbaier
Copy link
Author

hansfbaier commented Jan 23, 2022

@bl0x Very cool, thanks!

@whitequark
Copy link
Member

whitequark commented Feb 9, 2022

The LEDResources, ButtonResources and other similar helpers are intended to simplify a common case when defining resources, and to nudge the board definition file author towards our conventions. They are not in any way required to define LED, button, etc. resources; so for the relatively rare case where a resource with a custom name is needed, they can be expanded in the board definition file.

See also #192 (comment).

@bl0x
Copy link

bl0x commented Feb 9, 2022

The LEDResources, ButtonResources and other similar helpers are intended to simplify a common case when defining resources, and to nudge the board definition file author towards our conventions. They are not in any way required to define LED, button, etc. resources; so for the relatively rare case where a resource with a custom name is needed, they can be expanded in the board definition file.

See also #192 (comment).

Perhaps this can be mentioned in the documentation?

@whitequark
Copy link
Member

whitequark commented Feb 9, 2022

Sure, once there's actual documentation for the board DSL. (This will likely come after the redesign of the board DSL, so...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants