TinyFPGA AX2: Set internal oscillator as default#136
Open
jreyesr wants to merge 2 commits intoamaranth-lang:mainfrom
Open
TinyFPGA AX2: Set internal oscillator as default#136jreyesr wants to merge 2 commits intoamaranth-lang:mainfrom
jreyesr wants to merge 2 commits intoamaranth-lang:mainfrom
Conversation
Contributor
|
FWIW, I checked out both this PR and amaranth-lang/amaranth#575 locally. They both work fine when paired with some quality-of-life changes I intend to submit after this PR is merged. |
Contributor
|
@jreyesr There seems to be a bit of MachXO* activity in Amaranth as I type this. So it jogged my memory about this; would you be willing to mark this as ready to merge now that #575 was merged? |
Author
|
Hello @cr1901! Wow, it's been a while. Yes, this PR is ready to merge from my side, I just rebased the changes on top of current |
whitequark
approved these changes
Feb 7, 2025
9efeb4f to
fbd8e18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: In draft mode and awaiting for upstream PR to be merged
This PR changes the TinyFPGA AX2 board to use the internal high-speed oscillator by default, since the board has no external clock and thus no default
syncdomain.Notice: This PR is dependent on amaranth-lang/amaranth#575 being merged. Until then, it would cause an error since OSCH is not a valid resource on the TinyFPGA AX2 board.