nandland_go: 7seg displays should be inverted #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit sets
invert=True
for the two 7-segment displays the Nandland Go has, as the signals should be inverted for the 7-segment displays to work properly. I also tested this on the Nandland Go by implementing an 8-bit counter that uses both 7-segment displays to display the current value in hex. I also verified that the DP pin is indeed hardwired to 3V3 instead of being controllable from the FPGA (see page 2 of the Nandland Go board schematic.