Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cmod_a7 board. #185

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

bl0x
Copy link

@bl0x bl0x commented Oct 8, 2021

I just got a Cmod A7 35 today to play around with. So, here ya go!

Copy link
Contributor

@rroohhh rroohhh left a comment

Is there a specific reason you are leaving out the (P)SRAM and the 1-wire crypto element?

nmigen_boards/cmod_a7.py Outdated Show resolved Hide resolved
nmigen_boards/cmod_a7.py Outdated Show resolved Hide resolved
nmigen_boards/cmod_a7.py Outdated Show resolved Hide resolved
@bl0x
Copy link
Author

bl0x commented Oct 8, 2021

@rroohhh , thanks for the review and comments!

crypto: I have no idea what this pin is for, and what is connected to it. But no problem, I could add it as a Connector.

sram: I forgot about it, mainly because I don't need it (now). I'll put it in.

@bl0x
Copy link
Author

bl0x commented Oct 13, 2021

Dear @rroohhh , am I still missing something?

nmigen_boards/cmod_a7.py Outdated Show resolved Hide resolved
nmigen_boards/cmod_a7.py Outdated Show resolved Hide resolved
nmigen_boards/cmod_a7.py Outdated Show resolved Hide resolved
nmigen_boards/cmod_a7.py Outdated Show resolved Hide resolved
nmigen_boards/cmod_a7.py Outdated Show resolved Hide resolved
@bl0x
Copy link
Author

bl0x commented Oct 21, 2021

I think that all things are fixed now.

@bl0x
Copy link
Author

bl0x commented Nov 24, 2021

I've rebased to current nmigen:master

@bl0x
Copy link
Author

bl0x commented Dec 10, 2021

@rroohhh Am I missing something to make this ready for merging?

@bl0x
Copy link
Author

bl0x commented Dec 19, 2021

Hi,

I've migrated from nmigen->amaranth.
The failing test is for genesys2, so unrelated to these commits.

@rroohhh
Copy link
Contributor

rroohhh commented Dec 19, 2021

@rroohhh Am I missing something to make this ready for merging?

Looks fine from what I can see, but @whitequark is the maintainer, I was just interested in the board and took a look :)

@bl0x
Copy link
Author

bl0x commented Jan 23, 2022

I rebased onto main and updated. Also fixed two more things.

@bl0x
Copy link
Author

bl0x commented Jan 23, 2022

This PR now depends on PR 054b5c1 (or a similar solution) to be merged. Otherwise the test for genesys2 will fail again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants