Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Digilent Genesys2 board #49

Merged
merged 7 commits into from
May 28, 2020
Merged

Add Digilent Genesys2 board #49

merged 7 commits into from
May 28, 2020

Conversation

peteut
Copy link
Contributor

@peteut peteut commented Feb 29, 2020

The Blinky test works fine on my board.

@peteut peteut mentioned this pull request Feb 29, 2020
Closed
whitequark
whitequark requested changes Mar 21, 2020
View reviewed changes
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 3, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
39a0337
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 3, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
5642572
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 3, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
4144f1f
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 3, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
b2eb2ef
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 3, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
05aa15e
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 3, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
d8536dd
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 4, 2020
@peteut
genesys2: updates as proposed, refer to amaranth-lang#49.
62ea747
@peteut peteut requested a review from whitequark May 4, 2020 00:43
whitequark
whitequark requested changes May 8, 2020
View reviewed changes
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! There are a few more things I'd like you to change though.

nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated
Subsignal("scl", Pins("AE19", dir="io")),
Subsignal("sda", Pins("AF18", dir="io")),
Attrs(IOSTANDARD="LVCMOS18")),
Resource("oled", 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What interface does the display actually implement? SPI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whitequark it's an SPI interface w/o cs and miso pins. SPIResource expects those pins to be present. How should I tackle this?

nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
nmigen_boards/genesys2.py Outdated Show resolved Hide resolved
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 11, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
06692df
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 14, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
600ab69
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 17, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
6faf19b
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 17, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
c8ac365
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 17, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
ebc34d8
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 17, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
0565d18
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 17, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
2dc043c
peteut added a commit to peteut/nmigen-boards that referenced this pull request May 17, 2020
@peteut
genesys2: cleanup, refer to amaranth-lang#49. WIP.
1dc1846
@whitequark whitequark merged commit 86ae791 into amaranth-lang:master May 28, 2020
@whitequark
Copy link
Member

Thank you for your patience! All looks good to me now.

@peteut peteut deleted the nmigen-boards-1-master branch May 28, 2020 05:59
@igrr igrr mentioned this pull request Jun 8, 2020
Closed
rroohhh pushed a commit to rroohhh/nmigen-boards that referenced this pull request Aug 4, 2020
@whitequark
hdl.ast: fix typo.
81ee2db 
Fixes amaranth-lang#49.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitequark whitequark whitequark requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peteut @whitequark