Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lattice MachXO3LF Starter Kit #66

Merged
merged 2 commits into from Jun 21, 2020
Merged

Add Lattice MachXO3LF Starter Kit #66

merged 2 commits into from Jun 21, 2020

Conversation

trabucayre
Copy link
Contributor

@trabucayre trabucayre commented Jun 20, 2020

Hello,
This is the board definition for the Lattice MachX03LF Starter Kit.
Successfully tested with the blinky example.

Regards,
Gwenhael Goavec-Merou

@whitequark
Copy link
Member

whitequark commented Jun 20, 2020

Thanks for the PR; looks reasonable to me. There's one minor issue though; are you sure that using the MachXO2 platform is appropriate?

@trabucayre
Copy link
Contributor Author

trabucayre commented Jun 20, 2020

I'm agree, it's seems a bit strange but all my tests with this platform and my machXO3 based board works well...
In fact, before sending this PR, I have hesitated due to this "detail".
Of course maybe I'm wrong but...

@whitequark
Copy link
Member

whitequark commented Jun 20, 2020

Okay, I checked and all of the primitives match between MachXO2 and MachXO3L, so we should rename the platform to something like vendor.lattice_machxo_2_3l.

@trabucayre
Copy link
Contributor Author

trabucayre commented Jun 20, 2020

True. It's maybe less error prone.
Would you like I do it? with this name?

@whitequark
Copy link
Member

whitequark commented Jun 20, 2020

Would you like I do it? with this name?

Yes. Please look at how it's done for Xilinx, and do the same for MachXO.

@whitequark whitequark merged commit 7153d13 into amaranth-lang:master Jun 21, 2020
@whitequark
Copy link
Member

whitequark commented Jun 21, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants