Merged
Conversation
Member
|
I think these two boards should be in the same module. You could say that this should apply to the Versa ECP5 too, and you would be correct; I shouldn't have split those two. (Actually, Versa should probably even be one platform with a parameter? I'm still working out the best way to do this.) |
jeanthom
suggested changes
Jul 7, 2020
nmigen_boards/ecpix5_85.py
Outdated
| Subsignal("ba", Pins("U6 N3 N4", dir="o")), | ||
| Subsignal("dqs", DiffPairs("V4 V1", "U5 U2", dir="io"), Attrs(IO_TYPE="SSTL135D_I")), | ||
| Subsignal("dq", Pins("T4 W4 R4 W5 R6 P6 P5 P4 R1 W3 T2 V3 U3 W1 T1 W2", dir="io")), | ||
| Subsignal("dm", Pins("J4 H5", dir="o")), |
There was a problem hiding this comment.
Pinout error, this is the correct pinout:
Subsignal("dm", Pins("U4 U1", dir="o")),
nmigen_boards/ecpix5_85.py
Outdated
| Subsignal("dqs", DiffPairs("V4 V1", "U5 U2", dir="io"), Attrs(IO_TYPE="SSTL135D_I")), | ||
| Subsignal("dq", Pins("T4 W4 R4 W5 R6 P6 P5 P4 R1 W3 T2 V3 U3 W1 T1 W2", dir="io")), | ||
| Subsignal("dm", Pins("J4 H5", dir="o")), | ||
| Subsignal("odt", Pins("L2", dir="o")), |
There was a problem hiding this comment.
Pinout error, this is the correct pin:
Subsignal("odt", Pins("P3", dir="o")),
Member
Author
|
updates:
|
whitequark
approved these changes
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a separate platform for each ECPIX-5 variant (LFE5UM5G-45F and 85F).
The SD card interface is missing, but will be added later (once we sort out how to integrate it with
SDCardResources).The
Blinkytest does nothing currently, because the board does not have user leds, only RGB. We cannot just add someLEDResourcesthat share their pins with the RGB leds (like the fomu platforms do), because they rely on aPULLMODE="up"constraint, so requesting only one pin would leave the two others unconstrained.