Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECPIX-5 support. #71

Merged
merged 1 commit into from Jul 9, 2020
Merged

Add ECPIX-5 support. #71

merged 1 commit into from Jul 9, 2020

Conversation

@jfng
Copy link
Contributor

@jfng jfng commented Jul 1, 2020

This PR provides a separate platform for each ECPIX-5 variant (LFE5UM5G-45F and 85F).

The SD card interface is missing, but will be added later (once we sort out how to integrate it with SDCardResources).

The Blinky test does nothing currently, because the board does not have user leds, only RGB. We cannot just add some LEDResources that share their pins with the RGB leds (like the fomu platforms do), because they rely on a PULLMODE="up" constraint, so requesting only one pin would leave the two others unconstrained.

@whitequark
Copy link
Member

@whitequark whitequark commented Jul 1, 2020

I think these two boards should be in the same module. You could say that this should apply to the Versa ECP5 too, and you would be correct; I shouldn't have split those two. (Actually, Versa should probably even be one platform with a parameter? I'm still working out the best way to do this.)

Subsignal("ba", Pins("U6 N3 N4", dir="o")),
Subsignal("dqs", DiffPairs("V4 V1", "U5 U2", dir="io"), Attrs(IO_TYPE="SSTL135D_I")),
Subsignal("dq", Pins("T4 W4 R4 W5 R6 P6 P5 P4 R1 W3 T2 V3 U3 W1 T1 W2", dir="io")),
Subsignal("dm", Pins("J4 H5", dir="o")),
Copy link

@jeanthom jeanthom Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinout error, this is the correct pinout:

Subsignal("dm",     Pins("U4 U1", dir="o")),

Subsignal("dqs", DiffPairs("V4 V1", "U5 U2", dir="io"), Attrs(IO_TYPE="SSTL135D_I")),
Subsignal("dq", Pins("T4 W4 R4 W5 R6 P6 P5 P4 R1 W3 T2 V3 U3 W1 T1 W2", dir="io")),
Subsignal("dm", Pins("J4 H5", dir="o")),
Subsignal("odt", Pins("L2", dir="o")),
Copy link

@jeanthom jeanthom Jul 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinout error, this is the correct pin:

Subsignal("odt",    Pins("P3", dir="o")),

@jfng
Copy link
Contributor Author

@jfng jfng commented Jul 7, 2020

updates:

  • moved both platform variants in the same module
  • fixed wrong ddr3 pins
  • fixed wrong ulpi pin

@whitequark whitequark merged commit 01ebb87 into amaranth-lang:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants