Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orangecrab_r0_2: fix dq pin definitions. #80

Merged
merged 1 commit into from Jul 14, 2020

Conversation

@miek
Copy link
Contributor

@miek miek commented Jul 14, 2020

This fixes a bad pin definition due to string concatenation with no added space. I figured a long line was better than keeping the split string footgun, but I can redo it with a trailing space if you want to keep to a column width instead.

@whitequark
Copy link
Member

@whitequark whitequark commented Jul 14, 2020

I figured a long line was better than keeping the split string footgun

We split strings in quite a few places, but here it's kind of pointless because it exposes no underlying structure.

@whitequark whitequark merged commit 830e82a into amaranth-lang:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants